Skip to content

[UI] OAuth flow - Create & Delete PR + upgrade to WG 0.3.1 #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Oct 26, 2021

Conversation

foot
Copy link
Collaborator

@foot foot commented Oct 12, 2021

Uses weaveworks/weave-gitops#873

Fixes #136

If GITHUB_TOKEN env is set then flow is ignored.

To test: Deprecated, wg release 0.3.1-patch1 has the bits we need you can use the usual test flow

To test:

cd weave-gitops
git pull
git checkout export-ui-auth-helpers
rm -rf dist
make ui-lib

cd weave-gitops-enterprise
yarn add ~/weave/weave-gitops/dist
CAPI_SERVER_HOST=http://localhost:8000 yarn start

# new terminal
LOG_LEVEL=debug CAPI_CLUSTERS_NAMESPACE=default CAPI_TEMPLATES_NAMESPACE=default GIT_PROVIDER_TOKEN=$GITHUB_TOKEN GIT_PROVIDER_TYPE=github GIT_PROVIDER_HOSTNAME=github.com CAPI_TEMPLATES_REPOSITORY_URL=https://github.com/foot/wk-simon CAPI_TEMPLATES_REPOSITORY_BASE_BRANCH=master go run cmd/capi-server/main.go

@foot foot changed the base branch from main to upgrade-wg-0-3-1 October 12, 2021 14:04
@foot foot changed the base branch from upgrade-wg-0-3-1 to main October 13, 2021 14:20
@AlinaGoaga AlinaGoaga changed the title Auth flow create pr Auth flow - Create & Delete PR Oct 13, 2021
@AlinaGoaga
Copy link
Contributor

AlinaGoaga commented Oct 14, 2021

@foot I am sometimes getting the slow down error. I have attached screenshots from both apps, getting the same atm. I had a look in weave gitops and there seems to be a pollAuthStatus function that is meant to retry though I don't see that happening there either so the only way to get around it atm is to refresh and hope it doesn't happen again. Any preferences on how to handle?

Screenshot 2021-10-13 at 15 01 29
Screenshot 2021-10-14 at 11 46 32

@foot
Copy link
Collaborator Author

foot commented Oct 15, 2021

WG tried to address slow down here but might not be working here https://github.com/weaveworks/weave-gitops/pull/828/files

@foot foot added the enhancement New feature or request label Oct 15, 2021
@foot foot changed the title Auth flow - Create & Delete PR [UI] OAuth flow - Create & Delete PR + upgrade to WG 0.3.1 Oct 15, 2021
@foot foot mentioned this pull request Oct 18, 2021
2 tasks
@foot foot requested a review from AlinaGoaga October 25, 2021 14:19
@AlinaGoaga
Copy link
Contributor

Whop! Looks good to me! I've retested the app section and was able to get the commits after authenticating & refreshing the page.

@foot foot merged commit 9279546 into main Oct 26, 2021
@foot foot deleted the auth-flow-create-pr branch October 26, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Implement github oauth from core in EE
2 participants