Skip to content

Conversation

ahussein3
Copy link
Contributor

What Changes:

  • Disable the target checkbox if target namespace field is = flux-system
  • Add tooltip when checkbox is disabled

@ahussein3 ahussein3 requested review from foot and AlinaGoaga November 9, 2022 16:33
@ahussein3 ahussein3 self-assigned this Nov 9, 2022
@ahussein3 ahussein3 added bug_acceptance bugs found during qa / acceptance testing bug Something isn't working and removed bug_acceptance bugs found during qa / acceptance testing labels Nov 9, 2022
Copy link
Contributor

@AlinaGoaga AlinaGoaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, approved! Added a suggestion for the adding of the var but it's the same thing, happy to merge as is

    currentAutomation[index] = {
      ...automation,
      [fieldName as string]: value,
    };

    if (fieldName === 'target_namespace' && value === 'flux-system') {
      currentAutomation[index] = {
        ...currentAutomation[index],
        createNamespace: false,
      };
    }

@ahussein3 ahussein3 merged commit 42a057a into main Nov 10, 2022
@ahussein3 ahussein3 deleted the UI-1817-DisableCreateTargetNameSpaceIfNameSpaceIsFluxSystem branch November 10, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Add kustomization with Create target namespace for kustomization option fails for 'flux-system' target namespace
2 participants