Skip to content

Add cost estimate message if available #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 9, 2022
Merged

Add cost estimate message if available #1845

merged 2 commits into from
Nov 9, 2022

Conversation

ahussein3
Copy link
Contributor

Changes

  • show Estimate Message if available.
  • If Estimate low and high are the same Only show Cost without range.

@ahussein3 ahussein3 self-assigned this Nov 8, 2022
@ahussein3 ahussein3 added the enhancement New feature or request label Nov 8, 2022
@ahussein3 ahussein3 requested review from foot and AlinaGoaga November 8, 2022 16:22
@ahussein3 ahussein3 changed the title add cost estimate message if available Add cost estimate message if available Nov 8, 2022
foot
foot approved these changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works a treat!

@ahussein3 ahussein3 merged commit 9642e6d into main Nov 9, 2022
@ahussein3 ahussein3 deleted the UI-1767-AddMessageToCostEstimate branch November 9, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@AlinaGoaga AlinaGoaga Awaiting requested review from AlinaGoaga

Assignees

@ahussein3 ahussein3

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Add a message returned from cost-estimate api that is shown in the UI
2 participants
@ahussein3 @foot