Actually remove the watcher from the helm-watcher-cache #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor to support testing a bit better - Clean up logging
foot
changed the title
bigkevmcd
reviewed
Nov 4, 2022
| @@ -55,6 +64,8 @@ func (i *ClusterHelmIndexerTracker) Start(ctx context.Context, cm clustersmngr.C | |||
| watcher, ok := i.ClusterWatchers[removed.Name] | |||
| if ok { | |||
| watcher.Stop() | |||
| // remove the watcher from the map | |||
| delete(i.ClusterWatchers, removed.Name) | |||
There was a problem hiding this comment.
A big branch for this :-)
- Combine the fake caches - Clean up error handling
bigkevmcd
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1823
What changed?
We remove the watcher from our store if the clusterManager sends an update.Remove
Why was this change made?
It was overlooked / undertested when intro'd in #1631
How was this change implemented?
Bit of refactoring and adding the important line to remove the watcher from the store.
How did you validate the change?
More unit tests