-
Notifications
You must be signed in to change notification settings - Fork 2
[BE] Fix profile layering and default profiles installation #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Was mainly missing the fake httpserver
2 tasks
- Drop feature / code that pulls in values.yaml by default - Start passing the cache into the get-profiles stuff so we can try and read version / layer from it
e574590
to
9bf1964
Compare
6b2ba7a
to
a78af4f
Compare
440a0ad
to
45f9cf4
Compare
45f9cf4
to
918d303
Compare
918d303
to
2bfd345
Compare
- So we can id the profiles repo properly
foot
reviewed
Nov 21, 2022
5ce35c2
to
abcd30d
Compare
foot
reviewed
Nov 23, 2022
Co-authored-by: Simon <[email protected]>
foot
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:200:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1776
What changed?
Why was this change made?
How was this change implemented?
How did you validate the change?
Release notes
Documentation Changes