Add list of known CAPI providers #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
add-provider
branch
from
58ad684 to
06ba2af
Compare
yiannistri
force-pushed
the
add-provider
branch
2 times, most recently
from
881a1e5 to
02bd098
Compare
yiannistri
force-pushed
the
add-provider
branch
from
02bd098 to
fea8ff5
Compare
bigkevmcd
reviewed
Oct 8, 2021
…erprise into add-provider
foot
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Looks gold!
One tiny thing, we get a funny artifact in the dropdown if the provider is "" (e.g. broken template on test cluster)
So filtering out empty providers when building the autocomplete component might be a shout wdyt @AlinaGoaga ?
|
Ouch, yes, let me fix that now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awsazuredigitaloceandockergcpopenstackpacketvsphereNote: this is not a list of the CAPI providers that we have tested WGE with, just the list of CAPI providers we can recognise.
Fixes #162