Skip to content

Conversation

foot
Copy link
Collaborator

@foot foot commented Oct 21, 2022

What changed?

  • Server: Add a new controller that watches HelmReleases and populates the SQLite cache.
  • API: Add layer to /v1/charts/list response
  • API: Add RBAC check to /v1/charts/list and /v1/charts/values
  • UI: Switch to using /v1/charts/list and /v1/charts/values endpoints
  • Tooling: Fixes for cross-compiling to linux from darwin (NATIVE_BUILD=1 tilt up)

Why was this change made?

  • Next step in moving to Multi-Cluster index.yaml / values.yaml requests
  • Only queries the management cluster right now NOT other leaf clusters
  • Keeps existing profiles system in place to be removed in a follow up.

How did you validate the change?

  • Unit tests
  • Manual testing
  • Smoke tests still pass.

Follow ups

@foot foot added the enhancement New feature or request label Oct 21, 2022
@foot foot force-pushed the connect-up-helm-chart-endpoints branch from 008fd1a to a59daa2 Compare October 23, 2022 15:27
@foot foot marked this pull request as ready for review October 23, 2022 17:23
@foot foot requested review from sarataha and bigkevmcd October 24, 2022 08:52
Scheme: scheme,
Logger: ctrl.Log,
LeaderElection: false,
MetricsBindAddress: "0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled leader-election and metrics etc here as I don't think we need them.

Leader election can be useful during upgrades but

  • Probably will deploy with pod-local storage (?) so each clusters-service that ends up running will have an independent cache.
  • Multiple clusters-services writing to sqlite on a PVC is probably fine too. Might bump into some "database already open / locked" w/ multiple processes but controller retrying should eventually resolve.

Metrics need to open ports (?) so doing that for every cluster doesn't sound great.

The "manager level" still seems like the correct level to spawn for each cluster https://book.kubebuilder.io/architecture.html

Is this a bad idea @bigkevmcd ?

Copy link
Member

@sarataha sarataha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥇 🎉

@foot foot force-pushed the connect-up-helm-chart-endpoints branch from 145e82f to e66f554 Compare October 24, 2022 17:24
@foot foot merged commit 3eb7633 into main Oct 24, 2022
@foot foot deleted the connect-up-helm-chart-endpoints branch October 24, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants