Skip to content

Change helm versioning #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 20, 2022
Merged

Change helm versioning #1724

merged 5 commits into from
Oct 20, 2022

Conversation

MohamedMSaeed
Copy link
Contributor

What changed?

  1. Helm-version for helm in branches by adding timestamp except for main.
    • Before would be like: 0.9.5-33-gc5bee89
    • After will be like: 0.9.5-1666179549-g51a48a58
  2. Have helm repository per branch. Helm-repo will be dev/branches/$branchname

Why was this change made?
In order to make it easier to auto-reconcile WGE from branches via flux, we:

  1. Create a helm repository per branch
  2. Add a timestamp in the helm-version so flux can get the latest version in the repository.

How did you validate the change?
I tested it manually.

@MohamedMSaeed MohamedMSaeed requested a review from foot October 19, 2022 14:25
@foot foot added the exclude from release notes Use this label to exclude a PR from the release notes label Oct 19, 2022
foot
foot approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@MohamedMSaeed MohamedMSaeed merged commit 7a17470 into main Oct 20, 2022
@MohamedMSaeed MohamedMSaeed deleted the change-helm-versioning branch October 20, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MohamedMSaeed @foot