-
Notifications
You must be signed in to change notification settings - Fork 2
UI 1678 add cost estimation component to create cluster form #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI 1678 add cost estimation component to create cluster form #1708
Conversation
https://github.com/weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
…of github.com:weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
Hey @ahussein3, the cost estimate was missing from the
It won't be on the test clusters but if you have a local cluster you can apply the capa template manifest to that and test. If you do To start the BE: run In another window start the frontend with |
ui-cra/src/components/Clusters/Form/Partials/CostEstimation.tsx
Outdated
Show resolved
Hide resolved
ui-cra/src/components/Clusters/Form/Partials/CostEstimation.tsx
Outdated
Show resolved
Hide resolved
ui-cra/src/components/Clusters/Form/Partials/CostEstimation.tsx
Outdated
Show resolved
Hide resolved
ui-cra/src/components/Clusters/Form/Partials/CostEstimation.tsx
Outdated
Show resolved
Hide resolved
https://github.com/weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
…efactor view logic to util function
https://github.com/weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
https://github.com/weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
…into UI-1678-AddCostEstimationComponentToCreateClusterForm
…of github.com:weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ahussein3 this looks good! I've updated it with namespace in render template as the API changed a bit. I'd wait for Kevin's BE PR before merging as it's not clear to me how the data will come through (for example in the helper function we check amount !== undefined
- not sure if the amount will come through as undefined though, might be null?)
@AlinaGoaga as it's mentioned in the ticket the it will be either amount or range. So here if there is no amount it will be undefined. but yes we can sure merge when we see Data and Test it first. Thanks Alina |
https://github.com/weaveworks/weave-gitops-enterprise into UI-1678-AddCostEstimationComponentToCreateClusterForm
Closes [UI] Add "Estimate cost button" to templates form #1678
adding new component to receive cost estimation and view in the capa-cluster-template