Skip to content

Add entitlement check in gitops-repo-broker #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 11, 2021
Merged

Add entitlement check in gitops-repo-broker #170

merged 9 commits into from
Oct 11, 2021

Conversation

yiannistri
Copy link
Collaborator

@yiannistri yiannistri commented Oct 6, 2021 •
edited
Loading

  • Update GH actions to use Go 1.17
  • Move entitlement package to common module
  • Use entitlement middleware in gitops-repo-broker API
  • Replace logrus with zapr in gitops-repo-broker

Fixes #164

@yiannistri yiannistri self-assigned this Oct 6, 2021
@yiannistri yiannistri added the enhancement New feature or request label Oct 6, 2021
@yiannistri yiannistri force-pushed the entitlement-check branch 15 times, most recently from 040f541 to 84fd5e7 Compare October 6, 2021 19:44
foot
foot approved these changes Oct 8, 2021
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ , 🧹 , LGTM.

Only other little thing would be to add a test that the middleware checking is working in gitops-broker by firing up NewServer too maybe? If thats tricky we can leave for acceptance too.

bigkevmcd
bigkevmcd reviewed Oct 8, 2021
View reviewed changes
bigkevmcd
bigkevmcd reviewed Oct 11, 2021
View reviewed changes
@yiannistri yiannistri merged commit e35a2b7 into main Oct 11, 2021
@yiannistri yiannistri deleted the entitlement-check branch October 11, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd left review comments

@foot foot foot approved these changes

Assignees

@yiannistri yiannistri

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add entitlement checking to gitops-broker and event-writer
3 participants
@yiannistri @foot @bigkevmcd