Skip to content

Fix annotation parameters #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 13, 2022
Merged

Fix annotation parameters #1690

merged 3 commits into from
Oct 13, 2022

Conversation

ranatrk
Copy link
Contributor

@ranatrk ranatrk commented Oct 12, 2022

Fixes #1192

What changed?

  • annotation param names are included in the Params function call instead of being called seperatly in AllParamNames, so will always be checked for
  • template response tests are updated with profile annotations included

How did you validate the change?

  • Tests added including checking params returned included params found in the profile annotations
  • Manual check where UI includes the params from the profile annotation
    e.g: INSTALL_CRDS param added in form from profile annotation values
    Screenshot from 2022-10-12 18-10-13
    Screenshot from 2022-10-12 18-10-24

@ranatrk ranatrk added the bug Something isn't working label Oct 12, 2022
bigkevmcd
bigkevmcd approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I contributed to this so maybe another set of 👀 ?

@bigkevmcd bigkevmcd requested a review from foot October 12, 2022 16:54
@ranatrk ranatrk force-pushed the fix-annotation-parameters branch from 41b11b3 to b603139 Compare October 12, 2022 16:55
foot
foot approved these changes Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beaut! Tests ✨

bigkevmcd and others added 3 commits October 13, 2022 15:23
@bigkevmcd @ranatrk
Add tests for parsing annotations.
9dd5476 
This adds tests for parsing annotations with parameters.
@bigkevmcd @ranatrk
Broken tests.
ddd8219
@ranatrk
Fix processors test
0c27f73
@ranatrk ranatrk force-pushed the fix-annotation-parameters branch from b603139 to 0c27f73 Compare October 13, 2022 13:23
@ranatrk ranatrk merged commit 2b2e1a9 into main Oct 13, 2022
@ranatrk ranatrk deleted the fix-annotation-parameters branch October 13, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@bigkevmcd bigkevmcd bigkevmcd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BE] Parameters for annotations are not rendered in the form (UI create cluster form)
3 participants
@ranatrk @foot @bigkevmcd