Add gitops set config and gitops get config commands from WG OSS.
#1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opudrovs
changed the title
gitops set config and gitops get config commands from core.gitops set config and gitops get config commands from WG OSS.
opudrovs
force-pushed
the
add-gitops-set-config-and-get-config-commands
branch
from
4376f95 to
a39acf2
Compare
Yes please! Will try and do it tomorrow. |
opudrovs
force-pushed
the
add-gitops-set-config-and-get-config-commands
branch
3 times, most recently
from
2c79985 to
0632ca3
Compare
|
Hello! main is on #1695 now, so this would be great to merge sans the changes to go.mod/sum |
|
@ozamosi we are not merging this one yet too, until the legal docs are ready, correct? |
opudrovs
force-pushed
the
add-gitops-set-config-and-get-config-commands
branch
from
0632ca3 to
be423b7
Compare
|
@opudrovs Can we move this forward? |
|
@bigkevmcd I am on vacation now and will be able to check it on Monday. This and other Pendo WG OSS PRs are waiting for a Pendo-related documentation update. If it is urgent please ask @ozamosi or @josefaworks if these PRs are still blocked. |
opudrovs
force-pushed
the
add-gitops-set-config-and-get-config-commands
branch
from
be423b7 to
7c0f81a
Compare
opudrovs
force-pushed
the
add-gitops-set-config-and-get-config-commands
branch
from
7c0f81a to
af1f5ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
weaveworks/weave-gitops#2772
weaveworks/weave-gitops#2811
gitops set configandgitops add configin enterprise.The user ID set with
gitops set configwill be used with Pendo analytics.Please see the tickets' acceptance criteria for full examples of running the commands. But in general you can test the commands with
make cmd/gitops/gitopsand running: