Fix bug in InjectLabels. #1654
Merged
Fix bug in InjectLabels. #1654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was overwriting the labels on the resource, which was losing existing labels. This applies the new labels, overwriting existing labels in-place, but retaining the existing labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Fix InjectLabels.
This was overwriting the labels on the resource, which was losing existing labels.
This applies the new labels, overwriting existing labels in-place, but retaining the existing labels.
Why was this change made?
Fix a bug where it was overwriting existing labels.
How was this change implemented?
Trivial change to the code.
How did you validate the change?
Release notes
Documentation Changes