Update API response to include status.lastAppliedRevision fields #1643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
reviewed
Oct 4, 2022
jpellizzari
approved these changes
Oct 4, 2022
| @@ -866,10 +866,6 @@ exports[`Applications index test snapshots success 1`] = ` | |||
| text-overflow: ellipsis; | |||
| } | |||
|
|
|||
| .c15 .filter-options-chip { | |||
There was a problem hiding this comment.
Should this have changed?
There was a problem hiding this comment.
This happens a lot lately, when running npm test -- -u without even change a thing in application
| @@ -1,3 +1,4 @@ | |||
| /* eslint-disable testing-library/no-node-access */ | |||
There was a problem hiding this comment.
❓ Any idea why we would want to do DOM traversal here (had to look up what this rule did). https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/no-node-access.md
There was a problem hiding this comment.
We need to select an element from another element here and testing-library doesn't support all the functionality we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1606
What changed?
Set
lastAppliedRevisionto every workloadWhy was this change made?
Show requested and deployed version of a Helm Release within Pipelines details
Feedback from CX that:
Only showing the declared version makes it difficult to understand state when using semver range
Showing both the HelmRelease spec.chart.spec.version and status.lastAppliedRevision would help with users quickly trying to eyeball the state of their application rollout