Skip to content

Remove filter params from templates navigations #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2022
Merged

Remove filter params from templates navigations #1624

merged 1 commit into from
Sep 29, 2022

Conversation

ahussein3
Copy link
Contributor

@ahussein3 ahussein3 commented Sep 29, 2022 •
edited
Loading

  • Remove filters params from templates navigation as templates has no labels yet and that break the user experience

@ahussein3 ahussein3 requested a review from foot September 29, 2022 10:22
@ahussein3 ahussein3 added the exclude from release notes Use this label to exclude a PR from the release notes label Sep 29, 2022
foot
foot approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@ahussein3 ahussein3 merged commit 268d092 into main Sep 29, 2022
@ahussein3 ahussein3 deleted the UpdateCreateClusterBtn branch September 29, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahussein3 @foot