Skip to content

Form Validation and Create PR / Render functions cleanup #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 123 commits into from
Oct 18, 2022
Merged

Form Validation and Create PR / Render functions cleanup #1609

merged 123 commits into from
Oct 18, 2022

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Sep 27, 2022 •
edited by foot
Loading

Closes #1608
Closes #511

  • Form validation - bring it to parent Form level (atm it's at the Partial Form level)
  • Add form validation to PR Preview
  • BE functions - there's overlap between Create PR and Render functions - extract helpers
  • Fixes showing profiles payload in preview
  • Fixes preview for GitopsTemplates
  • Fixes createNamespace checkbox on create-cluster

AlinaGoaga and others added 30 commits September 2, 2022 18:58
@AlinaGoaga
WG1379 Add PR Preview to apps - WIP
b55408a
@AlinaGoaga
Add Profiles to PR Preview for Clusters - WIP and update render template
4fa096e
@AlinaGoaga
Merge branch 'main' of github.com:weaveworks/weave-gitops-enterprise …
4e5ad24 
…into pr-preview
@AlinaGoaga
Wrap fct in callback
c1bc17b
@AlinaGoaga
Add PR Preview tabs - WIP
6e2163b
@AlinaGoaga
Add PR Preview tabs - WIP2
ed68884
@AlinaGoaga
Update API to render kustomizations - WIP
4274864
@AlinaGoaga
Update API to render kustomizations - WIP2
570d475
@AlinaGoaga
Solve conflicts with main
564906c
@AlinaGoaga
Solve conflicts with main - 2
4001b33
@AlinaGoaga
Merge branch 'main' into pr-preview
f9274a8
@AlinaGoaga
Move renderKustomization out of templates
671bcfa
@AlinaGoaga
Merge branch 'pr-preview' of github.com:weaveworks/weave-gitops-enter…
793efc5 
…prise into pr-preview
@AlinaGoaga
Merge branch 'main' into pr-preview
0f7d304
@AlinaGoaga
Solve conflicts
a727e8b
@AlinaGoaga
Update API for Add App Preview
3928add
@AlinaGoaga
Update API for Add App Preview
3a5c366
@AlinaGoaga
Merge branch 'main' into pr-preview
929bbd8
@AlinaGoaga
Merge branch 'pr-preview' of github.com:weaveworks/weave-gitops-enter…
bb31b90 
…prise into pr-preview
@AlinaGoaga
Regenerate files
e459110
@AlinaGoaga
Adjust PR Preview for Add App
ae45b59
@AlinaGoaga
Merge branch 'main' into pr-preview
24a674d
@AlinaGoaga
Cleanup
9345712
@AlinaGoaga
Add test for render automations
5f3bab0
@AlinaGoaga
Merge branch 'pr-preview' of github.com:weaveworks/weave-gitops-enter…
d5ba17a 
…prise into pr-preview
@AlinaGoaga
Add test for render automations - 2
ebe847c
@AlinaGoaga
Add test for render templates with apps
46fe494
@AlinaGoaga
Merge branch 'main' into pr-preview
f0e0e1f
@AlinaGoaga
Add path to file
c70f01f
@AlinaGoaga
Merge branch 'main' into pr-preview
f5c6997
Base automatically changed from pr-preview to main October 6, 2022 09:54
@AlinaGoaga AlinaGoaga marked this pull request as ready for review October 10, 2022 17:29
@AlinaGoaga
Copy link
Contributor Author

@foot I've got the Create Cluster PR tests passing however on render template for Cluster they panic and I wasn't able to say why. Any ideas?

foot
foot reviewed Oct 10, 2022
View reviewed changes
foot
foot approved these changes Oct 18, 2022
View reviewed changes
Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Molto Bene! 🍝 🍕

@foot foot merged commit 60b727f into main Oct 18, 2022
@foot foot deleted the refactor branch October 18, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI/BE] Cleanup CLUSTER / APP Preview / Create PR Form and BE functions Create cluster preview PR does not show manifests related to profiles
3 participants
@AlinaGoaga @foot @ahussein3