Adding application add app test #1578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedfazal
force-pushed
the
add-application-test
branch
2 times, most recently
from
c3a629a to
176a2af
Compare
saeedfazal
force-pushed
the
add-application-test
branch
3 times, most recently
from
42fd958 to
0d35007
Compare
saeedfazal
force-pushed
the
add-application-test
branch
from
0d35007 to
3bd4864
Compare
foot
reviewed
Sep 27, 2022
| helmArgs+=( --set "policy-agent.accountId=weaveworks" ) | ||
| helmArgs+=( --set "policy-agent.clusterId=${MANAGEMENT_CLUSTER_CNAME}" ) | ||
| helmArgs+=( --set "policy-agent.config.accountId=weaveworks" ) | ||
| helmArgs+=( --set "policy-agent.config.clusterId=${MANAGEMENT_CLUSTER_CNAME}" ) |
foot
reviewed
Sep 27, 2022
| @@ -148,7 +152,8 @@ function setup { | |||
| helmArgs+=( --set "config.git.type=${GIT_PROVIDER}" ) | |||
| helmArgs+=( --set "config.git.hostname=${GIT_PROVIDER_HOSTNAME}" ) | |||
| helmArgs+=( --set "config.capi.repositoryURL=${GIT_REPOSITORY_URL}" ) | |||
| helmArgs+=( --set "config.capi.repositoryPath=./clusters/my-cluster/clusters" ) | |||
| # using default repository path '"./clusters/management/clusters"' so the application reconciliation always happen out of the box | |||
| # helmArgs+=( --set "config.capi.repositoryPath=./clusters/my-cluster/clusters" ) | |||
There was a problem hiding this comment.
#1475 😬 , will look into it..
foot
reviewed
Sep 27, 2022
| @@ -70,7 +70,7 @@ function setup_eks { | |||
| --exec-arg=--oidc-issuer-url=${OIDC_ISSUER_URL} \ | |||
| --exec-arg=--oidc-client-id=${DEX_CLI_CLIENT_ID} \ | |||
| --exec-arg=--oidc-client-secret=${DEX_CLI_CLIENT_SECRET} \ | |||
| --exec-arg=--oidc-extra-scope="openid email offline_access" \ | |||
| --exec-arg=--oidc-extra-scope="openid email groups offline_access" \ | |||
There was a problem hiding this comment.
Do we have to provide this explicitly?
There was a problem hiding this comment.
Yes, we to explicitly specify the claim in kubeconfig, otherwise groups can't be authenticated.
foot
reviewed
Sep 27, 2022
| @@ -1,4 +1,4 @@ | |||
| apiVersion: pac.weave.works/v1 | |||
| apiVersion: pac.weave.works/v2beta1 | |||
foot
reviewed
Sep 27, 2022
| @@ -11,6 +11,6 @@ identityProviders: | |||
| issuerUrl: "{{ISSUER_URL}}" | |||
| clientId: "{{CLIENT_ID}}" | |||
| usernameClaim: email | |||
| usernamePrefix: "-" | |||
There was a problem hiding this comment.
Ah this was the trick to AWS OIDC don't need it anymore?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1524
What changed?
Why was this change made?
Acceptance test coverage for add kustomization feature.