Skip to content

Remove count from breadcrumbs #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 21, 2022
Merged

Remove count from breadcrumbs #1564

merged 4 commits into from
Sep 21, 2022

Conversation

TheGostKasper
Copy link
Contributor

@TheGostKasper TheGostKasper commented Sep 21, 2022 •
edited
Loading

Closes #1551

What changed?
Remove count from breadcrumbs [ parent routes ]

Why was this change made?

We need to revisit the breadcrumbs in Enterprise and how they show the total number of objects. On some of our demo environments pages load incredibly slow. For example, I go to the “Delivery” page and it is looking for 1 object, but it has a spinning wheel as it pulls up 130 applications as well. This is super inefficient

How did you validate the change?
Tested locally, test cases covered in pipelineDetails & there will be more to come

@TheGostKasper TheGostKasper requested review from a team and removed request for foot, ahussein3 and AlinaGoaga September 21, 2022 13:50
jpellizzari
jpellizzari approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@jpellizzari jpellizzari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should be asking ourselves why we had to change this in so many files. Our pages/components repeat themselves a lot.

The count logic could have been encapsulated into a single component without too much trouble.

@TheGostKasper TheGostKasper merged commit 58ddf2a into main Sep 21, 2022
@TheGostKasper TheGostKasper deleted the 1551-remove-count branch September 21, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpellizzari jpellizzari jpellizzari approved these changes

Assignees
No one assigned
Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Remove count from breadcrumbs
2 participants
@TheGostKasper @jpellizzari