feat: Add tf-controller #1532
feat: Add tf-controller #1532
Conversation
yiannistri
added
the
exclude from release notes
Tiltfile
Outdated
| @@ -11,6 +11,9 @@ if not os.path.exists("../cluster-bootstrap-controller"): | |||
| if not os.path.exists("../cluster-controller"): | |||
| fail("You need to git clone https://github.com/weaveworks/cluster-controller to a directory next to this") | |||
|
|
|||
| if not os.path.exists("../tf-controller"): | |||
There was a problem hiding this comment.
Not crazy about being opinionated about directories. Can we instead keep a local copy of a helm chart in the repo?
There was a problem hiding this comment.
I would rather avoid duplication. Maybe we can add the HelmRepository/HelmRelease resources instead and let flux install it.
There was a problem hiding this comment.
What about using the helm_remote extension instead? I tested it locally and it seems to work.
load('ext://helm_remote', 'helm_remote')
helm_remote('tf-controller',
repo_name='tf-controller',
repo_url='https://weaveworks.github.io/tf-controller',
namespace='flux-system')There was a problem hiding this comment.
That's a good idea 👍 I tried with a directory of kustomizations and that worked too but I think we can keep it simple and use this extension ^^ instead.
There was a problem hiding this comment.
Also worried about things changing unexpectedly when main gets pulled on tf-controller
Added tf-controller to Tiltfile for WGE via a helm_remote extension. It currently uses the default Helm chart values. The extensions pulls in the Helm charts in
./helmwhich is why this has been added to .gitignore