Skip to content

Add support for Helm template functions #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Conversation

bigkevmcd
Copy link
Contributor

@bigkevmcd bigkevmcd commented Sep 15, 2022

This pulls in the same function library for text/template as Helm uses but removes some related to the OS and paths etc as these are not relevant in the environment.

This is the relevant Helm code https://github.com/helm/helm/blob/a499b4b179307c267bdf3ec49b880e3dbd2a5591/pkg/engine/funcs.go

This is the documentation for the library code http://masterminds.github.io/sprig/

And this is the Helm documentation for the same https://helm.sh/docs/chart_template_guide/function_list/

@steve-fraser this one's for you!

@bigkevmcd bigkevmcd requested a review from foot September 15, 2022 16:34
@bigkevmcd bigkevmcd added the enhancement New feature or request label Sep 15, 2022
@cmharden
Copy link

Sorry, I didn't mean to approve this.

Copy link
Collaborator

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Maybe one more test trying to use env or another stripped fn to see it failing?

This pulls in the same function library for text/template as Helm uses
but removes some related to the OS and paths etc as these are not
relevant in the environment.

Signed-off-by: Kevin McDermott <[email protected]>
@bigkevmcd bigkevmcd force-pushed the template-string-replace branch from e80e434 to 539eb3e Compare September 16, 2022 08:21
@bigkevmcd bigkevmcd merged commit a9bf030 into main Sep 16, 2022
@bigkevmcd bigkevmcd deleted the template-string-replace branch September 16, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants