Skip to content

Allow specifying multiple groupNames in tenancy file #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2022
Merged

Allow specifying multiple groupNames in tenancy file #1455

merged 2 commits into from
Sep 6, 2022

Conversation

foot
Copy link
Collaborator

@foot foot commented Sep 6, 2022 •
edited
Loading

  • Pass them straight through to the rolebinding
  • Adds a couple of validation tests

Fixes #1435

@foot
Allow specifying multiple groupNames in tenancy file
48c0916 
- Pass them straight through to the rolebinding
- Adds a couple of validation tests
@foot foot added the enhancement New feature or request label Sep 6, 2022
alichaddad
alichaddad approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@alichaddad alichaddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foot foot merged commit 78f6eb5 into main Sep 6, 2022
@foot foot deleted the tenancy-allow-multiple-groupnames branch September 6, 2022 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd approved these changes

+1 more reviewer

@alichaddad alichaddad alichaddad approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple groups association is not supported in tenant manifest yaml
3 participants
@foot @bigkevmcd @alichaddad