init backward comptablity for policies v1 #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waleedhammam
added
the
exclude from release notes
waleedhammam
force-pushed
the
1283-policies-backward-comptablity
branch
2 times, most recently
from
acfd0c9 to
f67475f
Compare
waleedhammam
force-pushed
the
1283-policies-backward-comptablity
branch
from
f67475f to
c9298f5
Compare
waleedhammam
force-pushed
the
1283-policies-backward-comptablity
branch
5 times, most recently
from
7f5d9e5 to
b2876c0
Compare
alichaddad
approved these changes
Aug 31, 2022
waleedhammam
force-pushed
the
1283-policies-backward-comptablity
branch
from
b2876c0 to
8ad590d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow
1- Check for v2beta policies
2- If errors check for v1 policies too
3- return v2beta and/or v1 policies
4- If no policies don't return error just nil as it doesn't make sense to show an error in case of no policies