Skip to content

update Navbar icons to change its color once it's active #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2022
Merged

update Navbar icons to change its color once it's active #1345

merged 2 commits into from
Aug 23, 2022

Conversation

TheGostKasper
Copy link
Contributor

@TheGostKasper TheGostKasper commented Aug 23, 2022 •
edited
Loading

As we export icons from Figma, we have a tiny issue with the color change to the SVG icons as it blocks by default any change to change its color .

This PR fixes it by removing fill attr out of SVG files and update the height & width for each Icon .

@TheGostKasper TheGostKasper self-assigned this Aug 23, 2022
@TheGostKasper
Copy link
Contributor Author

I choose not use Material Icons here to keep it as it's as we don't have any supported icon for policy & flux runtime
image image image

@bia

@TheGostKasper TheGostKasper merged commit 1079ed4 into main Aug 23, 2022
@TheGostKasper TheGostKasper deleted the update-svg-icons-to-change-colors branch August 23, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahussein3 ahussein3 ahussein3 approved these changes

@jpellizzari jpellizzari Awaiting requested review from jpellizzari

Assignees

@TheGostKasper TheGostKasper

Labels
area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheGostKasper @ahussein3