Skip to content

Fixes create tenant policy output so flux can apply it #1342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2022
Merged

Fixes create tenant policy output so flux can apply it #1342

merged 1 commit into from
Aug 23, 2022

Conversation

foot
Copy link
Collaborator

@foot foot commented Aug 23, 2022

  • Flux doesn't like null values

Fixes #1325

@foot foot requested a review from alichaddad August 23, 2022 12:27
@foot foot added the bug Something isn't working label Aug 23, 2022
alichaddad
alichaddad approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@alichaddad alichaddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@foot foot merged commit 39bd870 into main Aug 23, 2022
@foot foot deleted the fixes-flux-applying-tenancy-policy branch August 23, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alichaddad alichaddad alichaddad approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gitops create tenant --export that generates policy cannot be applied by flux
2 participants
@foot @alichaddad