Skip to content

Avoid duplication on AlertListError component #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 15, 2022
Merged

Avoid duplication on AlertListError component #1287

merged 9 commits into from
Aug 15, 2022

Conversation

TheGostKasper
Copy link
Contributor

It fixes #1278

@TheGostKasper TheGostKasper added bug Something isn't working team/sunglow labels Aug 14, 2022
@TheGostKasper TheGostKasper self-assigned this Aug 14, 2022
ahussein3
ahussein3 requested changes Aug 14, 2022
View reviewed changes
@ahussein3
Copy link
Contributor

This issue will be fixed by that #1203

@TheGostKasper
Copy link
Contributor Author

@ahussein3 we experienced an error with the key in cluster-name as described in the issue and @luizbafilho explained why this error happened k8s missing around also you will find a suggestion for better visualizing Error message and cluster name and namespace - It's just a suggestion .

@ahussein3
Copy link
Contributor

@TheGostKasper #1203 is merged that duplicate of errors should be fixed by now.

luizbafilho
luizbafilho approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@luizbafilho luizbafilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, just make sure to get the progressive delivery change in place to append the version.

@TheGostKasper TheGostKasper merged commit c519943 into main Aug 15, 2022
@TheGostKasper TheGostKasper deleted the 1278-avoid-duplicate-errors branch August 15, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahussein3 ahussein3 ahussein3 approved these changes

+1 more reviewer

@luizbafilho luizbafilho luizbafilho approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@TheGostKasper TheGostKasper

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid duplication on AlertListError component
3 participants
@TheGostKasper @ahussein3 @luizbafilho