-
Notifications
You must be signed in to change notification settings - Fork 2
Fixes CAPI Status appearing in the UI #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Needed to pipe the CAPIEnabled through our layers any layers of config a little bit more
See smoke tests running in checks above ^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me, I am not sure that the func opts need to be exported tho' as they aren't used outside of the package.
I would lean towards stripping a layer or two our of this whole config dance we have right now. Including the |
Yes, we aren't using them outside the package, so other than the readability part, there's not currently a huge benefit. They could be unexported... |
Or deleted and replaced with a struct? wdyt? |
- Dealing with maps..
a little bit more
Fixes #1227