Skip to content

[UI] Stop infinite request loop on application-detail page #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

foot
Copy link
Collaborator

@foot foot commented Sep 23, 2021

  • Currently getting an infinite loop of requests on /application_detail

Also adds more base permissions to capi-service so it get get/list profiles stuff and capi-stuff that:

Fixes #108

@foot foot changed the title Stop infinte request loop going on [UI] Stop infinite request loop on application-detail page Sep 24, 2021
@foot foot requested a review from AlinaGoaga September 24, 2021 07:45
Copy link
Contributor

@AlinaGoaga AlinaGoaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks for fixing Simon! Sorry, my mistake, when I added the check for the function I introduced the listApplications in dependencies (despite there being a comment in there - facepalm)

@foot foot merged commit 5a6998e into main Sep 24, 2021
@foot foot deleted the fixes-infinite-loading-loop branch September 24, 2021 10:28
@foot foot added the bug Something isn't working label Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WG app dependency graph doesn't render if capi-service doesn't have RBAC to list/get all the resources in the graph
2 participants