Update /v1/clusters to accept a list of workloads
#1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foot
reviewed
Jul 19, 2022
foot
reviewed
Jul 19, 2022
| err = multierror.Append(err, invalidNamespaceErr) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Maybe add another test for this fn a couple of invalid messages?
bigkevmcd
reviewed
Jul 20, 2022
| @@ -609,6 +609,28 @@ func validateCreateClusterPR(msg *capiv1_proto.CreatePullRequestRequest) error { | |||
| } | |||
| } | |||
|
|
|||
| for _, k := range msg.Kustomizations { | |||
| if k.Name == "" { | |||
| err = multierror.Append(err, fmt.Errorf("kustomization name must be specified")) | |||
There was a problem hiding this comment.
This could be just errors.New("kustomization name must be specified") as you're not formatting anything.
|
|
||
| if k.SourceRef != nil { | ||
| if k.SourceRef.Name == "" { | ||
| err = multierror.Append(err, fmt.Errorf("sourceRef name must be specified")) |
There was a problem hiding this comment.
Same issue with Errorf here, but perhaps we could include the name of the kustomization (k.Name) in the error message to help with diagnosing?
| return files, nil | ||
| } | ||
|
|
||
| func getClusterKustomizationsPath(cluster types.NamespacedName, ns, name string) string { |
There was a problem hiding this comment.
This looks like it should be two types.NamespacedName values?
foot
approved these changes
Jul 26, 2022
| @@ -609,6 +614,28 @@ func validateCreateClusterPR(msg *capiv1_proto.CreatePullRequestRequest) error { | |||
| } | |||
| } | |||
|
|
|||
| for _, k := range msg.Kustomizations { | |||
| if k.Metadata.Name == "" { | |||
There was a problem hiding this comment.
This might panic if k.Metadata is nil? Could we add one more test where we omit Metadata in the request?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1079
PR to update
/v1/clustersendpoint to: