Skip to content

Fixed CI failing tests due to policy-agent namspace creation #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2022
Merged

Fixed CI failing tests due to policy-agent namspace creation #1074

merged 1 commit into from
Jul 11, 2022

Conversation

saeedfazal
Copy link
Contributor

@saeedfazal saeedfazal commented Jul 11, 2022 •
edited
Loading

  • Creating namespace explicitly while installing policy-agent
  • Enable leaf cluster policy test to run in Deploy job

@saeedfazal saeedfazal added the exclude from release notes Use this label to exclude a PR from the release notes label Jul 11, 2022
@saeedfazal saeedfazal self-assigned this Jul 11, 2022
makkes
makkes reviewed Jul 11, 2022
View reviewed changes
Copy link
Member

@makkes makkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also https://github.com/weaveworks/weave-gitops-enterprise/blob/main/tools/dev-resources.yaml that I patched to contain the Namespace manifest which fixed it locally for me. Do we want to include the Namespace manifest there, too?

@foot foot merged commit c0920ce into main Jul 11, 2022
@foot foot deleted the fix-failing-violation-tests branch July 11, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makkes makkes makkes left review comments

@foot foot foot approved these changes

Assignees
No one assigned
Labels
exclude from release notes Use this label to exclude a PR from the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saeedfazal @foot @makkes