Cleanup ProgressiveDelivery hooks #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
force-pushed
the
jp-pd-cleanup
branch
from
20f6aaa to
d6fb4a5
Compare
jpellizzari
added
the
exclude from release notes
jpellizzari
force-pushed
the
jp-pd-cleanup
branch
from
d6fb4a5 to
0a84591
Compare
TheGostKasper
approved these changes
Jul 8, 2022
There was a problem hiding this comment.
LGTM 👏
@bia , You're ok with separating Icon in new Column ?
|
Yes, that looks much better, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1038
Unifies the hooks under the
ProgressiveDeliverycontext.Also moves icons into their own column to avoid ugliness:
Before:
After:
