UI: provide cluster namespace when fetching kubeconfig #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makkes
force-pushed
the
kubeconfig-provide-ns
branch
from
6025a22 to
38b7fcb
Compare
foot
approved these changes
Jul 4, 2022
makkes
changed the title
When a cluster is created in a namespace that's different from the
default one ("default") then downloading the kubeconfig failed because
the UI didn't provide the cluster's namespace to the server.
With this change, the namespace is provided as a query parameter.
makkes
force-pushed
the
kubeconfig-provide-ns
branch
from
38b7fcb to
6cb261b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a cluster is created in a namespace that's different from the
default one ("default") then downloading the kubeconfig failed because
the UI didn't provide the cluster's namespace to the server.
With this change, the namespace is provided as a query parameter.