Leaf cluster policies acceptance test #1025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeedfazal
force-pushed
the
policies-leaf-cluster-test
branch
7 times, most recently
from
24aa28b to
000dad8
Compare
foot
reviewed
Jul 1, 2022
test/acceptance/test/cli_upgrade.go
Outdated
| _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/default/%s.yaml", repoAbsolutePath, clusterName)) | ||
| // Enable new path chenking when upograding to clusters across namespaces WGE release | ||
| // _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/default/%s.yaml", repoAbsolutePath, clusterName)) | ||
| _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/%s.yaml", repoAbsolutePath, clusterName)) |
foot
approved these changes
Jul 1, 2022
saeedfazal
force-pushed
the
policies-leaf-cluster-test
branch
from
a7fe711 to
b16e163
Compare
foot
reviewed
Jul 6, 2022
test/acceptance/test/cli_upgrade.go
Outdated
| _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/default/%s.yaml", repoAbsolutePath, clusterName)) | ||
| // Enable new path chenking when upograding to clusters across namespaces WGE release | ||
| // _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/default/%s.yaml", repoAbsolutePath, clusterName)) | ||
| _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/%s.yaml", repoAbsolutePath, clusterName)) |
There was a problem hiding this comment.
I mean.. I think it is 🤔 , there should be a conflict here.. 👀
There was a problem hiding this comment.
Ah! When we change the upgrade version to 0.9.0-rc.3 this will change, there was a lot of churn y'day.
Suggested change
| _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/%s.yaml", repoAbsolutePath, clusterName)) | |
| _, err := os.Stat(fmt.Sprintf("%s/clusters/capi/clusters/quick-capi/%s.yaml", repoAbsolutePath, clusterName)) |
There was a problem hiding this comment.
I have removed it in my PR, as it is fixed in main
saeedfazal
force-pushed
the
policies-leaf-cluster-test
branch
from
45824de to
7efea16
Compare
saeedfazal
force-pushed
the
policies-leaf-cluster-test
branch
from
7efea16 to
5911e88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #759