Skip to content

Conversation

@sawka
Copy link
Member

@sawka sawka commented Oct 16, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

CountCustomSettings in pkg/wconfig/settingsconfig.go was changed to also exclude autoupdate:channel (in addition to telemetry:enabled). Telemetry schema in pkg/telemetry/telemetrydata/telemetrydata.go adds a new OnboardingGithubStar field and registers the event name "onboarding:githubstar". Frontend types (frontend/types/gotypes.d.ts) change onboarding.githubstar from boolean to the union "already" | "star" | "later". Frontend onboarding components log the new telemetry event and several external links (onboarding and About modal) now append ref= query parameters. Documentation adds release notes and a new wsh blocks reference section (duplicated in two places).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The provided title only describes excluding the autoupdate channel in custom settings but the pull request also includes telemetry enhancements, front-end link updates, type changes, and documentation additions, so it does not summarize the main scope of the changeset in a concise way. Consider revising the title to reflect the broader scope of changes such as adding GitHub star telemetry, updating front-end links, and documentation, or split this pull request into more focused pieces each with a clear title.
Description Check ⚠️ Warning No pull request description was provided, leaving reviewers without any context or summary of the changes. A description is expected to at least outline the purpose and scope of the modifications. Please add a description summarizing the key changes and objectives of this pull request so reviewers can quickly understand its intent.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch sawka/fix-customsettings

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 07c0d2c and 0000b68.

📒 Files selected for processing (2)
  • docs/docs/releasenotes.mdx (2 hunks)
  • docs/docs/wsh-reference.mdx (1 hunks)
🧰 Additional context used
🪛 LanguageTool
docs/docs/releasenotes.mdx

[grammar] ~19-~19: There might be a mistake here.
Context: ...ommand output directly to Wave AI using wsh ai - Smart Context Switching - Enable Wave ...

(QB_NEW_EN)


[grammar] ~34-~34: There might be a mistake here.
Context: ...g blocks by workspace, tab, or view type - Continued migration from SCSS to Tailwin...

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Build Docsite
  • GitHub Check: Analyze (go)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Build for TestDriver.ai
  • GitHub Check: merge-gatekeeper

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sawka sawka merged commit 38163e7 into main Oct 16, 2025
10 checks passed
@sawka sawka deleted the sawka/fix-customsettings branch October 16, 2025 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant