- 
                Notifications
    You must be signed in to change notification settings 
- Fork 505
feat(cli): add blocks list with filtering and JSON output #2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from 3 commits
      Commits
    
    
            Show all changes
          
          
            6 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      5350fbd
              
                feat(cli): add blocks list with filtering and JSON output
              
              
                mister-x-ops c5dba04
              
                add more comments and use all workspaces by default
              
              
                mister-x-ops a52c831
              
                address Nitpick comments
              
              
                mister-x-ops 52252ce
              
                readjust output and fix other remarks from AI
              
              
                mister-x-ops 8677306
              
                other Nitpick's suggestions
              
              
                mister-x-ops 2ee23b7
              
                merge main
              
              
                sawka File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,254 @@ | ||
| // Copyright 2025, Command Line Inc. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|  | ||
| package cmd | ||
|  | ||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "sort" | ||
| "strings" | ||
|  | ||
| "github.com/spf13/cobra" | ||
| "github.com/wavetermdev/waveterm/pkg/waveobj" | ||
| "github.com/wavetermdev/waveterm/pkg/wshrpc" | ||
| "github.com/wavetermdev/waveterm/pkg/wshrpc/wshclient" | ||
| ) | ||
|  | ||
| // Command-line flags for the blocks commands | ||
| var ( | ||
| blocksWindowId string // Window ID to filter blocks by | ||
| blocksWorkspaceId string // Workspace ID to filter blocks by | ||
| blocksTabId string // Tab ID to filter blocks by | ||
| blocksView string // View type to filter blocks by (term, web, etc.) | ||
| blocksJSON bool // Whether to output as JSON | ||
| blocksTimeout int // Timeout in seconds for RPC calls | ||
| ) | ||
|  | ||
| // BlockDetails represents the information about a block returned by the list command | ||
| type BlockDetails struct { | ||
| BlockId string `json:"blockid"` // Unique identifier for the block | ||
| WorkspaceId string `json:"workspaceid"` // ID of the workspace containing the block | ||
| TabId string `json:"tabid"` // ID of the tab containing the block | ||
| Meta waveobj.MetaMapType `json:"meta"` // Block metadata including view type | ||
| } | ||
|  | ||
| // blocksListCmd represents the 'blocks list' command | ||
| var blocksListCmd = &cobra.Command{ | ||
| Use: "list", | ||
| Aliases: []string{"ls", "get"}, | ||
| Short: "List blocks in workspaces/windows", | ||
| Long: `List blocks with optional filtering by workspace, window, tab, or view type. | ||
|  | ||
| Examples: | ||
| # List blocks from all workspaces | ||
| wsh blocks list | ||
|  | ||
| # List only terminal blocks | ||
| wsh blocks list --view=term | ||
|  | ||
| # Filter by window ID (get IDs from 'wsh workspace list') | ||
| wsh blocks list --window=dbca23b5-f89b-4780-a0fe-452f5bc7d900 | ||
|  | ||
| # Filter by workspace ID | ||
| wsh blocks list --workspace=12d0c067-378e-454c-872e-77a314248114 | ||
|  | ||
| # Output as JSON for scripting | ||
| wsh blocks list --json`, | ||
| RunE: blocksListRun, | ||
| PreRunE: preRunSetupRpcClient, | ||
| SilenceUsage: true, | ||
| } | ||
|  | ||
| // init registers the blocks commands with the root command | ||
| // It configures all the flags and command options | ||
| func init() { | ||
| blocksListCmd.Flags().StringVar(&blocksWindowId, "window", "", "restrict to window id") | ||
| blocksListCmd.Flags().StringVar(&blocksWorkspaceId, "workspace", "", "restrict to workspace id") | ||
| blocksListCmd.Flags().StringVar(&blocksTabId, "tab", "", "restrict to tab id") | ||
| blocksListCmd.Flags().StringVar(&blocksView, "view", "", "restrict to view type (term/terminal, web/browser, preview/edit, sysinfo, waveai)") | ||
| blocksListCmd.Flags().BoolVar(&blocksJSON, "json", false, "output as JSON") | ||
| blocksListCmd.Flags().IntVar(&blocksTimeout, "timeout", 5, "timeout in seconds for RPC calls") | ||
|  | ||
| for _, cmd := range rootCmd.Commands() { | ||
| if cmd.Use == "blocks" { | ||
| cmd.AddCommand(blocksListCmd) | ||
| return | ||
| } | ||
| } | ||
|  | ||
| blocksCmd := &cobra.Command{ | ||
| Use: "blocks", | ||
| Short: "Manage blocks", | ||
| Long: "Commands for working with blocks", | ||
| } | ||
|  | ||
| blocksCmd.AddCommand(blocksListCmd) | ||
| rootCmd.AddCommand(blocksCmd) | ||
| } | ||
|  | ||
| // blocksListRun implements the 'blocks list' command | ||
| // It retrieves and displays blocks with optional filtering by workspace, window, tab, or view type | ||
| func blocksListRun(cmd *cobra.Command, args []string) error { | ||
| var allBlocks []BlockDetails | ||
|  | ||
| workspaces, err := wshclient.WorkspaceListCommand(RpcClient, &wshrpc.RpcOpts{Timeout: int64(blocksTimeout * 1000)}) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to list workspaces: %v", err) | ||
| } | ||
|  | ||
| if len(workspaces) == 0 { | ||
| return fmt.Errorf("no workspaces found") | ||
| } | ||
|  | ||
| var workspaceIdsToQuery []string | ||
|  | ||
| // Determine which workspaces to query | ||
| if blocksWorkspaceId != "" && blocksWindowId != "" { | ||
| return fmt.Errorf("--workspace and --window are mutually exclusive; specify only one") | ||
| } | ||
| if blocksWorkspaceId != "" { | ||
| workspaceIdsToQuery = []string{blocksWorkspaceId} | ||
| } else if blocksWindowId != "" { | ||
| // Find workspace ID for this window | ||
| windowFound := false | ||
| for _, ws := range workspaces { | ||
| if ws.WindowId == blocksWindowId { | ||
| workspaceIdsToQuery = []string{ws.WorkspaceData.OID} | ||
| windowFound = true | ||
| break | ||
| } | ||
| } | ||
| if !windowFound { | ||
| return fmt.Errorf("window %s not found", blocksWindowId) | ||
| } | ||
| } else { | ||
| // Default to all workspaces | ||
| for _, ws := range workspaces { | ||
| workspaceIdsToQuery = append(workspaceIdsToQuery, ws.WorkspaceData.OID) | ||
| } | ||
| } | ||
|  | ||
| // Query each selected workspace | ||
| for _, wsId := range workspaceIdsToQuery { | ||
| req := wshrpc.BlocksListRequest{WorkspaceId: wsId} | ||
| if blocksWindowId != "" { | ||
| req.WindowId = blocksWindowId | ||
| } | ||
|  | ||
| blocks, err := wshclient.BlocksListCommand(RpcClient, req, &wshrpc.RpcOpts{Timeout: int64(blocksTimeout * 1000)}) | ||
| if err != nil { | ||
| WriteStderr("Warning: couldn't list blocks for workspace %s: %v\n", wsId, err) | ||
| continue | ||
| } | ||
|  | ||
| // Apply filters | ||
| for _, b := range blocks { | ||
| if blocksTabId != "" && blocksTabId != "current" && b.TabId != blocksTabId { | ||
| continue | ||
| } | ||
|  | ||
| if blocksView != "" { | ||
| view := b.Meta.GetString(waveobj.MetaKey_View, "") | ||
|  | ||
| // Support view type aliases | ||
| if !matchesViewType(view, blocksView) { | ||
| continue | ||
| } | ||
| } | ||
|  | ||
| allBlocks = append(allBlocks, BlockDetails{ | ||
| BlockId: b.BlockId, | ||
| WorkspaceId: b.WorkspaceId, | ||
| TabId: b.TabId, | ||
| Meta: b.Meta, | ||
| }) | ||
| } | ||
| } | ||
|  | ||
| // Output results | ||
| if blocksJSON { | ||
| bytes, err := json.MarshalIndent(allBlocks, "", " ") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to marshal JSON: %v", err) | ||
| } | ||
| WriteStdout("%s\n", string(bytes)) | ||
| return nil | ||
| } | ||
|         
                  coderabbitai[bot] marked this conversation as resolved.
              Outdated
          
            Show resolved
            Hide resolved | ||
|  | ||
| if len(allBlocks) == 0 { | ||
| WriteStdout("No blocks found\n") | ||
| return nil | ||
| } | ||
|  | ||
| // Stable ordering | ||
| sort.Slice(allBlocks, func(i, j int) bool { | ||
| if allBlocks[i].WorkspaceId != allBlocks[j].WorkspaceId { | ||
| return allBlocks[i].WorkspaceId < allBlocks[j].WorkspaceId | ||
| } | ||
| if allBlocks[i].TabId != allBlocks[j].TabId { | ||
| return allBlocks[i].TabId < allBlocks[j].TabId | ||
| } | ||
| return allBlocks[i].BlockId < allBlocks[j].BlockId | ||
| }) | ||
| format := "%-36s %-10s %-36s %-15s %s\n" | ||
| WriteStdout(format, "BLOCK ID", "WORKSPACE", "TAB ID", "VIEW", "CONTENT") | ||
|  | ||
| for _, b := range allBlocks { | ||
| blockID := b.BlockId | ||
| if len(blockID) > 36 { | ||
| blockID = blockID[:34] + ".." | ||
| } | ||
| view := b.Meta.GetString(waveobj.MetaKey_View, "<unknown>") | ||
| var content string | ||
|  | ||
| switch view { | ||
| case "preview", "edit": | ||
| content = b.Meta.GetString(waveobj.MetaKey_File, "<no file>") | ||
| case "web": | ||
| content = b.Meta.GetString(waveobj.MetaKey_Url, "<no url>") | ||
| case "term": | ||
| content = b.Meta.GetString(waveobj.MetaKey_CmdCwd, "<no cwd>") | ||
| default: | ||
| content = "" | ||
| } | ||
|  | ||
| wsID := b.WorkspaceId | ||
| if len(wsID) > 10 { | ||
| wsID = wsID[0:8] + ".." | ||
| } | ||
|  | ||
| tabID := b.TabId | ||
| if len(tabID) > 36 { | ||
| tabID = tabID[0:34] + ".." | ||
| } | ||
|  | ||
| WriteStdout(format, blockID, wsID, tabID, view, content) | ||
| } | ||
|  | ||
| return nil | ||
| } | ||
|  | ||
| // matchesViewType checks if a view type matches a filter, supporting aliases | ||
| func matchesViewType(actual, filter string) bool { | ||
| // Direct match (case insensitive) | ||
| if strings.EqualFold(actual, filter) { | ||
| return true | ||
| } | ||
|  | ||
| // Handle aliases | ||
| switch strings.ToLower(filter) { | ||
| case "preview", "edit": | ||
| return strings.EqualFold(actual, "preview") || strings.EqualFold(actual, "edit") | ||
| case "terminal", "term", "shell", "console": | ||
| return strings.EqualFold(actual, "term") | ||
| case "web", "browser", "url": | ||
| return strings.EqualFold(actual, "web") | ||
| case "ai", "waveai", "assistant": | ||
| return strings.EqualFold(actual, "waveai") | ||
| case "sys", "sysinfo", "system": | ||
| return strings.EqualFold(actual, "sysinfo") | ||
| } | ||
|  | ||
| return false | ||
| } | ||
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Fix --tab=current: it’s silently ignored; either implement or reject explicitly.
Current logic treats "current" as no-op and returns all tabs, which is misleading. Reject it up-front for now and simplify the in-loop filter.
Also applies to: 100-106
🤖 Prompt for AI Agents