update js deps #2255
update js deps #2255
Conversation
WalkthroughThe pull request updates version ranges in two files:
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
50-50: Consider aligning @types/node to Electron’s Node runtime (optional).Electron 34 embeds Node 20.x. Using
@types/node@^22can surface types for APIs not present at runtime. Consider targeting Node 20 types for the Electron main process (or separate tsconfigs per target).Apply this minimal adjustment if you want runtime-aligned types:
- "@types/node": "^22.13.17", + "@types/node": "^20",Alternatively, keep
@types/node@^22in the renderer (browser-like) tsconfig and settypes: ["node20"]in the main-process tsconfig to scope types per environment.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
docs/package.json(2 hunks)package.json(5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Build Docsite
- GitHub Check: Build for TestDriver.ai
- GitHub Check: merge-gatekeeper
🔇 Additional comments (8)
docs/package.json (3)
42-47: ESLint 9 + Prettier config — flat config verifiedFound flat config files and no legacy .eslintrc* configs. Search results:
- eslint.config.js (repo root)
- docs/eslint.config.js
- No .eslintrc* files detected
- No config references to @typescript-eslint/parser or @typescript-eslint/eslint-plugin (only occurrences are in yarn.lock: @typescript-eslint@8.39.1)
Conclusion: flat config is in use and there’s no evidence of legacy .eslintrc-based setup. No changes required from this check.
36-36: Sass bump OK — docusaurus-plugin-sass present and compatibleQuick check: docs/package.json includes docusaurus-plugin-sass@^0.2.6 and sass@^1.90.0, and the docs workspace uses @docusaurus/core@^3.7.0 with engines.node >=18 — this satisfies the plugin's requirements (plugin expects Docusaurus v2/v3 and sass installed). No changes required.
- File: docs/package.json
- dependencies: "docusaurus-plugin-sass": "^0.2.6", "sass": "^1.90.0", "@docusaurus/core": "^3.7.0"
- engines: "node": ">=18.0"
57-58: TypeScript 5.9 + typescript-eslint 8 alignment: LGTM — workspace consistent.Both package.json files use the same versions (no mismatches found):
- ./package.json — typescript: ^5.9.2, typescript-eslint: ^8.39.1
- ./docs/package.json — typescript: ^5.9.2, typescript-eslint: ^8.39.1
package.json (5)
33-36: Storybook/Chromatic, ESLint, Rollup plugin bumps: LGTM.These are compatible with your current Storybook 8.5 and Vite 6 ecosystem.
45-45: Tailwind Vite plugin is wired in the Vite config — no change neededVerified: electron.vite.config.ts imports the plugin and calls tailwindcss() (import at electron.vite.config.ts:4; usage at electron.vite.config.ts:83). package.json lists "@tailwindcss/vite": "^4.0.17".
- Checked files: electron.vite.config.ts (import + plugin usage), package.json
76-80: Tailwind v4 — please verify config & @tailwind directivesI searched the repo for tailwind.config.* and @tailwind directives but found no matches, so I can't confirm the Tailwind v4 migration is safe. Please validate the migration manually — specifically check:
- tailwind.config.(js|cjs|mjs|ts) — ensure the content/presets/plugins shape matches Tailwind v4.
- postcss.config.js / your build pipeline — confirm PostCSS and Tailwind plugin setup for v4.
- Global CSS entry files (e.g., src/index.css, styles/tailwind.css, src/styles/*.css|.scss) — verify @tailwind base/components/utilities directives are present and valid.
- package.json scripts that run tailwindcss/postcss — confirm CLI flags and build steps remain compatible.
Note: package.json lists "tailwindcss": "^4.1.12".
118-162: Runtime dependency bumps: LGTM but import-scan returned no matches — please verifyBumps to debug, papaparse, recharts, rxjs, tailwind-merge, ws, yaml look within compatible majors and no obvious red flags. However, the import-surface scan you ran produced no output in the sandbox, so I couldn't confirm there are no renamed/removed exports that might break imports.
- File to check: package.json (lines 118–162) — runtime deps bumped.
- Please run this local import scan and paste the output (or confirm it’s empty) so I can re-check:
# search ES module imports rg -n -C1 -g '!**/node_modules/**' "from\s+['\"](papaparse|recharts|rxjs|tailwind-merge|ws|yaml|debug)['\"]" # search CommonJS requires rg -n -C1 -g '!**/node_modules/**' "require\(['\"](papaparse|recharts|rxjs|tailwind-merge|ws|yaml|debug)['\"]\)"
71-71: Tailwind v4 + @tailwindcss/vite — no duplicate PostCSS plugin detectedI checked the repo: there are no postcss.config.* files, and Tailwind is wired through the Vite plugin — I didn't find a PostCSS tailwind plugin that would double-process styles.
Files of interest:
- package.json — devDependencies include "@tailwindcss/vite": "^4.0.17", "tailwindcss": "^4.1.12", and "postcss": "^8.5.6".
- electron.vite.config.ts — imports "@tailwindcss/vite" and calls tailwindcss().
- frontend/tailwindsetup.css — contains @import "tailwindcss";
- No postcss.config.* files found in the repo.
Recommendation: No change required now. If you later add a postcss.config.js that includes the tailwindcss PostCSS plugin (require('tailwindcss')), remove that plugin (or the Vite plugin) to avoid double-processing.
| "typescript": "^5.9.2", | ||
| "typescript-eslint": "^8.39.1", | ||
| "vite": "^6.1.6", | ||
| "vite-plugin-image-optimizer": "^1.1.9", | ||
| "vite-plugin-static-copy": "^2.2.0", | ||
| "vite-plugin-svgr": "^4.3.0", | ||
| "vite-tsconfig-paths": "^5.1.4", | ||
| "vitest": "^3.0.5" | ||
| "vitest": "^3.0.9" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Vite 6, TS 5.9, Vitest 3: LGTM; consider enforcing a Node engine for contributors.
Tooling here expects Node >= 18 (often >= 20 recommended). Consider specifying an engines field to avoid local env drift.
You could add this at the root (outside the selected lines), if desired:
"engines": {
"node": ">=18.18.0"
}Also ensure CI uses a compatible Node version.
🏁 Script executed:
#!/bin/bash
# Check for existing engines field and Node requirement
jq -r '.engines // empty' package.jsonLength of output: 40
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== package.json exists? =="
if [ -f package.json ]; then
echo "yes"
else
echo "no"
exit 0
fi
echo
echo "== package.json engines field (via python) =="
python - <<'PY'
import json,sys
try:
with open('package.json') as f:
pkg=json.load(f)
engines=pkg.get('engines')
if engines is None:
print("<no engines field>")
else:
import pprint
pprint.pprint(engines)
except Exception as e:
print("ERROR parsing package.json:", e)
PY
echo
echo "== Top-level Node version helper files =="
for f in .nvmrc .node-version .tool-versions; do
if [ -f "$f" ]; then
echo "$f: present"
echo "----"
sed -n '1,20p' "$f"
echo "----"
else
echo "$f: absent"
fi
done
echo
echo "== Search GitHub workflows for Node setup / node-version =="
if [ -d ".github/workflows" ]; then
rg -n --hidden --no-ignore -S "actions/setup-node|node-version" .github/workflows || echo "<no matches in .github/workflows>"
else
echo ".github/workflows: absent"
fi
echo
echo "== Search repo for 'engines' occurrences =="
rg -n --hidden --no-ignore -S "\"engines\"|node-version|\\.nvmrc" -g '!.git/**' || echo "<no matches found>"Length of output: 2526
Enforce Node engine in root package.json
Root package.json currently has no "engines" field (verified). CI workflows reference env.NODE_VERSION and docs/package.json already contains an engines entry — please add an engines field to the repo root and align CI.
Files to update:
- package.json (root): add engines field
- .github/workflows/*: ensure env.NODE_VERSION (or setup-node node-version) matches the engines value
- docs/package.json: verify engines stays consistent with the root
Suggested snippet to add to package.json (root):
"engines": {
"node": ">=18.18.0"
}Also consider adding an .nvmrc/.node-version for contributors or documenting the required Node version in README/CONTRIBUTING.
🤖 Prompt for AI Agents
In package.json around lines 85 to 93, the root package.json lacks an "engines"
field required by CI and docs; add an "engines" entry specifying the Node
version (e.g., node >=18.18.0) to the root package.json, then update
.github/workflows/* to ensure env.NODE_VERSION or the setup-node node-version
matches that engines value, and verify docs/package.json still matches the same
engines constraint; optionally add an .nvmrc or .node-version file (or update
README/CONTRIBUTING) to document the required Node version for contributors.
1 participant
No description provided.