-
Notifications
You must be signed in to change notification settings - Fork 203
Wrpc update and preparation for resource support #2370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Signed-off-by: luk3ark <[email protected]>
Second go round, big thanks to @rvolosatovs for the help:
|
Signed-off-by: luk3ark <[email protected]>
I believe this is now addressed given that #2459 is merged? |
Feature or Problem
Related Issues
Added TODO note to double-check wasi mapping - I think these started raising an error now that unmapped bindings generate errors...
Temporarily commented out some trait implementations for capability providers to allow for compilation. These need to be implemented back in before the end of this pull request to support first-hand interfaces in wasmCloud @ricochet . Need to implement with newest WRPC API, so these will likely change in form anyway.
To resolve this, we need to determine the best way to map different invocation types. Options include:
Update provider sdk after wrpc implementation has been signed off
Implement resources on top of new wrpc integration, which can move forward once @rvolosatovs is able to finalize resource support natively in wrpc.
Consumer Impact
Make sure we have support for wrpc and new bindings for providers or port to new style. This may have some breaking changes as @brooksmtownsend
Other improvements