Skip to content

Conversation

@lachieh
Copy link
Contributor

@lachieh lachieh commented Oct 29, 2025

Feature or Problem

Updates assorted eslint plugins and fixes issues that arose from new/adjusted rules

Related Issues

#398

Release Information

Next

Consumer Impact

Nothing here since this is an internal package.

Testing

Tests all still pass as expected for linting changes

@lachieh lachieh requested review from a team as code owners October 29, 2025 19:12
@wasmcloud-automation-app
Copy link
Contributor

wasmcloud-automation-app bot commented Oct 29, 2025

Unnecessary Changesets

The following package(s) are private and do not need a changeset:

  • washboard-ui
  • @wasmcloud/eslint-config

Changed Packages

Package Name Package Path Changeset Bump Current Version
washboard-ui apps/washboard-ui patch v0.8.3
@wasmcloud/eslint-config packages/eslint-config patch v0.1.4
@wasmcloud/lattice-client-core packages/lattice-client-core patch v0.5.9
@wasmcloud/lattice-client-react packages/lattice-client-react patch v0.5.9

Copy link
Contributor

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Didn't look super closely but stuff like changing ElementRef to ComponentRef is interesting -- do we have some react specific lint rules? This was mixed with manual changes?

@lachieh
Copy link
Contributor Author

lachieh commented Oct 30, 2025

Yeah, that was manual. It got deprecated so I updated while I was in there fixing other lint changes.

@lachieh lachieh enabled auto-merge (rebase) October 30, 2025 05:04
@lachieh lachieh disabled auto-merge October 30, 2025 05:10
@lachieh lachieh enabled auto-merge (rebase) October 30, 2025 05:12
@lachieh lachieh disabled auto-merge October 30, 2025 05:14
@lachieh lachieh force-pushed the lachieh/eslint-updates-unicorn-react-hooks branch from 774c855 to 020c03e Compare October 30, 2025 13:54
@lachieh lachieh enabled auto-merge (rebase) October 30, 2025 13:55
@lachieh lachieh merged commit efca02c into wasmCloud:main Oct 30, 2025
14 checks passed
@lachieh lachieh deleted the lachieh/eslint-updates-unicorn-react-hooks branch October 30, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants