chore(weave): Add serialization assertions for the remaining data types: Evaluation Library Types (4) #5578
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
tssweeney
changed the title
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f1b508750215c74f62096b785181e0b8194ae900 |
| # Sad ... equality is really a pain to assert here (and is broken) | ||
| # TODO: Write a good equality check and make it work | ||
| equality_check=lambda a, b: True, |
There was a problem hiding this comment.
Maybe this should be fixed before merging
There was a problem hiding this comment.
I agree. However, I am really trying to just get the current expectations fixed so that I can modify for a customer.
There was a problem hiding this comment.
Maybe I am missing something -- isn't the assert the expectation? How can you be sure unless the test actually passes?
There was a problem hiding this comment.
oh, the equality check is just one of many assertions. we do a bunch of validation on the actual payloads as well.
Adds Evaluation library objects