Skip to content

Conversation

@tssweeney
Copy link
Collaborator

@tssweeney tssweeney commented Oct 15, 2025

  1. Adds container types to the test suite

@tssweeney tssweeney requested a review from a team as a code owner October 15, 2025 01:59
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wandbot-3000
Copy link

wandbot-3000 bot commented Oct 15, 2025

@tssweeney tssweeney changed the title chore(weave): Add serialization assertions for the remaining data types: Container Types chore(weave): Add serialization assertions for the remaining data types: Container Types (1) Oct 15, 2025
@tssweeney tssweeney changed the title chore(weave): Add serialization assertions for the remaining data types: Container Types (1) chore(weave): Add serialization assertions for the remaining data types: Container Types (2) Oct 15, 2025
Copy link
Collaborator

@andrewtruong andrewtruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also test the nested case

Base automatically changed from tim/add_remaining_types_to_test_suite to master October 15, 2025 07:56
@tssweeney tssweeney merged commit e68362d into master Oct 15, 2025
205 of 207 checks passed
@tssweeney tssweeney deleted the tim/additional_types branch October 15, 2025 08:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants