chore(weave): fix test flakiness #5566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chance-wnb
force-pushed
the
chance/test_flakiness_fix
branch
from
bef9ebd to
a0d1995
Compare
chance-wnb
commented
Oct 13, 2025
| assert 5 <= test_thread.p50_turn_duration_ms <= 200 # Reasonable range for P50 | ||
| assert 5 <= test_thread.p99_turn_duration_ms <= 200 # Reasonable range for P99 | ||
| assert 0 <= test_thread.p50_turn_duration_ms | ||
| assert 0 <= test_thread.p99_turn_duration_ms |
Contributor
Author
There was a problem hiding this comment.
testing test_thread.p50_turn_duration_ms <= test_thread.p99_turn_duration_ms below should already be quite sufficient.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=f2db2477cb6e4d882a0eccae86c7770f3b935914 |
chance-wnb
force-pushed
the
chance/test_flakiness_fix
branch
from
a0d1995 to
06747e4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relaxes the test assertions for turn duration percentiles in the client trace tests. Instead of requiring specific ranges (5-200ms), the PR now only asserts that the values are positive, while maintaining that p99 is greater than or equal to p50.
Testing
Validate through CI