Skip to content

Conversation

rmarscher
Copy link
Member

@rmarscher rmarscher commented Jun 5, 2025

Part of the fix for #1437.

It turns out that #1437 is reporting multiple issues:

  1. Showing preview element content instead of a transition when navigating to a previously visited page. That issue is replicated with the e2e tests in this PR and fixed.
  2. Updating the url before changing the route. I'm expecting the url to not update until the new page has loaded. I opened fix: update url after route change #1459.
  3. The changeRoute function completes before the page component has streamed any data.

Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jun 5, 2025 8:51pm

Copy link

codesandbox-ci bot commented Jun 5, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@dai-shi dai-shi merged commit b5ced66 into wakujs:main Jun 6, 2025
34 checks passed
@dai-shi dai-shi mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants