Skip to content

Conversation

danisharora099
Copy link
Collaborator

@danisharora099 danisharora099 commented Jul 22, 2025

Problem / Description

Due to this decision, we implemented a lightweight credential generator that bypasses Zerokit: js-waku#2335. However, this approach has been deemed insecure and non-robust. Credential generation should strictly use Zerokit.

Furthermore, js-waku does not require RLN proof generation or verification. Given that js-waku no longer maintains Relay support, the majority of entities within @waku/rln are unnecessary for this use case.


Solution

  • Upgrade Zerokit from 0.8.0 to rln-wasm@^0.2.0.
    - Remove all RLN-related code from @waku/rln, except for credential generation.

Notes

  • Resolves:
  • Related to:

Checklist

  • Code changes are covered by unit tests.
  • Code changes are covered by e2e tests, if applicable.
  • Dogfooding has been performed, if feasible.
  • A test version has been published, if required.
  • All CI checks pass successfully.

Copy link

github-actions bot commented Jul 22, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 70.31 KB (0%) 1.5 s (0%) 357 ms (-34.38% 🔽) 1.8 s
Waku Simple Light Node 122.09 KB (0%) 2.5 s (0%) 571 ms (+42.16% 🔺) 3.1 s
ECIES encryption 20.86 KB (0%) 418 ms (0%) 158 ms (-35.32% 🔽) 575 ms
Symmetric encryption 20.3 KB (0%) 406 ms (0%) 236 ms (+52.01% 🔺) 642 ms
DNS discovery 51.95 KB (0%) 1.1 s (0%) 380 ms (+16.89% 🔺) 1.5 s
Peer Exchange discovery 52.4 KB (0%) 1.1 s (0%) 361 ms (+41.65% 🔺) 1.5 s
Local Peer Cache Discovery 46.1 KB (0%) 922 ms (0%) 400 ms (+69.79% 🔺) 1.4 s
Privacy preserving protocols 53.54 KB (0%) 1.1 s (0%) 319 ms (-21.55% 🔽) 1.4 s
Waku Filter 55.25 KB (0%) 1.2 s (0%) 391 ms (+20.85% 🔺) 1.5 s
Waku LightPush 52.91 KB (0%) 1.1 s (0%) 381 ms (+31.4% 🔺) 1.5 s
History retrieval protocols 59.18 KB (0%) 1.2 s (0%) 318 ms (-29.39% 🔽) 1.6 s
Deterministic Message Hashing 28.42 KB (0%) 569 ms (0%) 246 ms (+16.56% 🔺) 814 ms

@danisharora099 danisharora099 changed the title chore: upgrade zerokit for CredentialsManager chore(rln)!: only support credentials generation Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant