Skip to content

Feat: ci cd setup #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 2, 2023
Merged

Feat: ci cd setup #33

merged 8 commits into from
Jul 2, 2023

Conversation

GoGiants1
Copy link
Member

@GoGiants1 GoGiants1 commented Jun 25, 2023 •
edited
Loading

closes #34

  • Add github action and secrets for ecr push

@GoGiants1 GoGiants1 changed the title Feat/ci cd setup Feat: ci cd setup Jun 25, 2023
@GoGiants1 GoGiants1 changed the base branch from master to dev June 25, 2023 06:27
@GoGiants1 GoGiants1 requested a review from GanziDaeyong June 25, 2023 06:27
@GoGiants1 GoGiants1 self-assigned this Jun 26, 2023
GanziDaeyong
GanziDaeyong requested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@GanziDaeyong GanziDaeyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 댓글 단거 한번만 확인 부탁드리겠습니다 ㅎㅎ

@GoGiants1 GoGiants1 requested a review from GanziDaeyong June 28, 2023 15:33
xxnpark
xxnpark approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@xxnpark xxnpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GoGiants1 수고하셨습니다! newline만 추가해주시면 될거같습니다

GanziDaeyong
GanziDaeyong approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@GanziDaeyong GanziDaeyong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! 브랜치 이름은 바꿀꺼면 api 레포도 싹 바꿔야 하니까, 다음에 서버분들 다같이 있을때 한번 논의해보죠 ㅎㅎ @xxnpark

@GoGiants1 GoGiants1 merged commit b867f30 into dev Jul 2, 2023
@GoGiants1 GoGiants1 deleted the feat/ci-cd-setup branch July 2, 2023 05:51
GoGiants1 added a commit that referenced this pull request Jul 2, 2023
@GoGiants1
Feat: ci cd setup (#33) (#36)
80bb92d 
* fix: parameter names and cron schedule

* fix: cron parameter
- cron exp restriction

* build: add Dockerfile

* build: add github ci/cd for crawler

* chore: add db port env

* fix: target branch of dev ci/cd

* fix

* fix: add newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GanziDaeyong GanziDaeyong GanziDaeyong approved these changes

@Junetrbl Junetrbl Awaiting requested review from Junetrbl

@tomatozoo tomatozoo Awaiting requested review from tomatozoo

+1 more reviewer

@xxnpark xxnpark xxnpark approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@GoGiants1 GoGiants1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

도커 파일 생성 후 ECR에 푸시
3 participants
@GoGiants1 @xxnpark @GanziDaeyong