Skip to content

feat: add dev crawler #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 28, 2023
Merged

feat: add dev crawler #32

merged 4 commits into from
May 28, 2023

Conversation

GoGiants1
Copy link
Member

@GoGiants1 GoGiants1 commented May 21, 2023 •
edited
Loading

Closes #31

  • aws 람다 함수에 dev db용 함수 추가
  • 파라미터 스토어에 dev db 추가

@GoGiants1 GoGiants1 self-assigned this May 21, 2023
@GoGiants1 GoGiants1 added the enhancement New feature or request label May 25, 2023
xxnpark
xxnpark approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@xxnpark xxnpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요 아래 하나만 확인해주세요!

GanziDaeyong
GanziDaeyong approved these changes May 27, 2023
View reviewed changes
Copy link
Contributor

@GanziDaeyong GanziDaeyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 그냥 궁금한건데, noti-staging쪽도 noti채널과 slack token은 동일한건가요?

@GoGiants1
Copy link
Member Author

@GanziDaeyong 넹 siksha-notifier 이 봇이 다 메세지 보내고 있는거로 파악했어요!

@GoGiants1
fix: cron parameter
e7f9acc 
- cron exp restriction
@GoGiants1
Copy link
Member Author

배포 완료했습니다. 머지할게요!

@GoGiants1 GoGiants1 merged commit fbb5a43 into master May 28, 2023
@GoGiants1 GoGiants1 deleted the feature/dev-crawler branch May 28, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GanziDaeyong GanziDaeyong GanziDaeyong approved these changes

@Junetrbl Junetrbl Awaiting requested review from Junetrbl

@tomatozoo tomatozoo Awaiting requested review from tomatozoo

+1 more reviewer

@xxnpark xxnpark xxnpark approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@GoGiants1 GoGiants1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev DB에 크롤링하는 설정 추가
3 participants
@GoGiants1 @xxnpark @GanziDaeyong