Second pass edits #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And restructure some of the headings
This roughly follows the suggestion from Jeffrey about splitting out the mostly-ok stuff from the not-justifiable stuff.
33 tasks
Saving only the part that matters (normalizing requests for identity).
torgo
reviewed
Aug 5, 2025
|
I still have some comments from @toreini to address, but thanks for helping here Dan. |
|
If there is anything I should do to help, just ping me @martinthomson . Thanks! |
|
We can continue the discussion on the issues you've opened. Your input has been very helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there are lots of things involved in handling @jyasskin's review and some general cleanup, I'm doing a mega-change, rather than deal with lots of little pieces. Commits by section, not individual issues.
Preview | Diff