Skip to content

Conversation

carmacleod
Copy link
Contributor

Single-character PR - easy review! :)

The Temperature label for the vertical slider in Slider Examples with aria-orientation and aria-valuetext is bold, but the labels for the text sliders (Fan and Heat/Cool) are not.

The css selector for label was just missing the . to make it a class selector (.label).

(No corresponding issue)

@github-actions
Copy link
Contributor

Regression test coverage:

Examples without any regression tests:

  • button/button_idl.html
  • dialog-modal/alertdialog.html

Examples missing some regression tests:

  • combobox/combobox-autocomplete-both.html:
    • combobox-id
  • combobox/combobox-autocomplete-list.html:
    • combobox-id
  • combobox/combobox-autocomplete-none.html:
    • combobox-id
  • combobox/grid-combo.html:
    • textbox-key-down-arrow
    • textbox-key-up-arrow
  • dialog-modal/datepicker-dialog.html:
    • textbox-aria-describedby
  • menu-button/menu-button-actions-active-descendant.html:
    • menu-up-arrow
    • menu-down-arrow
    • menu-character
  • spinbutton/datepicker-spinbuttons.html:
    • spinbutton-down-arrow
    • spinbutton-up-arrow
    • spinbutton-page-down
    • spinbutton-page-up
    • spinbutton-home
    • spinbutton-end
  • toolbar/toolbar.html:
    • toolbar-tab
    • toolbar-right-arrow
    • toolbar-left-arrow
    • toolbar-home
    • toolbar-end
    • toolbar-toggle-esc
    • toolbar-toggle-enter-or-space
    • toolbar-radio-enter-or-space
    • toolbar-radio-down-arrow
    • toolbar-radio-up-arrow
    • toolbar-button-enter-or-space
    • toolbar-menubutton-enter-or-space-or-down-or-up
    • toolbar-menu-enter-or-space
    • toolbar-menu-down-arrow
    • toolbar-menu-up-arrow
    • toolbar-menu-escape
    • toolbar-spinbutton-down-arrow
    • toolbar-spinbutton-up-arrow
    • toolbar-spinbutton-page-down
    • toolbar-spinbutton-page-up
    • toolbar-checkbox-space
    • toolbar-link-enter-or-space
    • toolbar-aria-controls
    • toolbar-button-aria-pressed
    • toolbar-button-aria-hidden
    • toolbar-radiogroup-role
    • toolbar-radiogroup-aria-label
    • toolbar-radio-role
    • toolbar-radio-aria-checked
    • toolbar-radio-aria-hidden
    • toolbar-button-aria-disabled
    • toolbar-menubutton-aria-label
    • toolbar-menubutton-aria-haspopup
    • toolbar-menubutton-aria-controls
    • toolbar-menubutton-aria-expanded
    • toolbar-menu-role
    • toolbar-menu-aria-label
    • toolbar-menuitemradio-role
    • toolbar-menuitemradio-aria-checked
    • toolbar-menuitemradio-tabindex
    • toolbar-spinbutton-role
    • toolbar-spinbutton-aria-label
    • toolbar-spinbutton-aria-valuenow
    • toolbar-spinbutton-aria-valuetext
    • toolbar-spinbutton-aria-valuemin
    • toolbar-spinbutton-aria-valuemax

Example pages with Keyboard or Attribute table rows that do not have data-test-ids:

  • dialog-modal/alertdialog.html
    • "Keyboard Support" table(s):
      • Tab
      • Shift + Tab
      • Escape
      • Command + S
      • Control + S
    • "Attributes" table(s):
      • alertdialog
      • aria-labelledby=IDREF
      • aria-describedby=IDREF
      • aria-modal=true
      • alert

SUMMARY:

55 example pages found.
2 example pages have no regression tests.
8 example pages are missing approximately 61 out of approximately 775 tests.

ERROR - missing tests:

Please write missing tests for this report to pass.

@charmarkk charmarkk self-requested a review November 10, 2020 19:37
@mcking65 mcking65 merged commit ee15d76 into master Dec 13, 2020
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Dec 13, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Dec 13, 2020
@mcking65 mcking65 deleted the slider-css branch December 13, 2020 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants