Skip to content

Conversation

pseudo-rnd-thoughts
Copy link
Collaborator

@pseudo-rnd-thoughts pseudo-rnd-thoughts commented Jul 5, 2025

Description

Updates CleanRL to Gymnasium v1.1, changing wrappers, increasing ale-py version, and python versions (3.9 to 3.13)

The pettingzoo implementation is broken as supersuit needs to be updated

Types of changes

  • Bug fix
  • New feature
  • New algorithm
  • Documentation

Checklist:

  • I've read the CONTRIBUTION guide (required).
  • I have ensured pre-commit run --all-files passes (required).
  • I have updated the tests accordingly (if applicable).
  • I have updated the documentation and previewed the changes via mkdocs serve.
    • I have explained note-worthy implementation details.
    • I have explained the logged metrics.
    • I have added links to the original paper and related papers.

If you need to run benchmark experiments for a performance-impacting changes:

  • I have contacted @vwxyzjn to obtain access to the openrlbenchmark W&B team.
  • I have used the benchmark utility to submit the tracked experiments to the openrlbenchmark/cleanrl W&B project, optionally with --capture_video.
  • I have performed RLops with python -m openrlbenchmark.rlops.
    • For new feature or bug fix:
      • I have used the RLops utility to understand the performance impact of the changes and confirmed there is no regression.
    • For new algorithm:
      • I have created a table comparing my results against those from reputable sources (i.e., the original paper or other reference implementation).
    • I have added the learning curves generated by the python -m openrlbenchmark.rlops utility to the documentation.
    • I have added links to the tracked experiments in W&B, generated by python -m openrlbenchmark.rlops ....your_args... --report, to the documentation.

# Conflicts:
#	.github/workflows/tests.yaml
#	cleanrl/c51.py
#	cleanrl/c51_atari.py
#	cleanrl/c51_atari_jax.py
#	cleanrl/c51_jax.py
#	cleanrl/ddpg_continuous_action.py
#	cleanrl/ddpg_continuous_action_jax.py
#	cleanrl/dqn.py
#	cleanrl/dqn_atari.py
#	cleanrl/dqn_atari_jax.py
#	cleanrl/dqn_jax.py
#	cleanrl/qdagger_dqn_atari_impalacnn.py
#	cleanrl/qdagger_dqn_atari_jax_impalacnn.py
#	cleanrl/sac_atari.py
#	cleanrl/sac_continuous_action.py
#	cleanrl/td3_continuous_action.py
#	cleanrl/td3_continuous_action_jax.py
#	cleanrl_utils/buffers.py
#	docs/get-started/basic-usage.md
#	poetry.lock
#	pyproject.toml
#	requirements/requirements-atari.txt
#	requirements/requirements-cloud.txt
#	requirements/requirements-dm_control.txt
#	requirements/requirements-docs.txt
#	requirements/requirements-envpool.txt
#	requirements/requirements-jax.txt
#	requirements/requirements-mujoco.txt
#	requirements/requirements-optuna.txt
#	requirements/requirements-pettingzoo.txt
#	requirements/requirements-procgen.txt
#	requirements/requirements.txt
# Conflicts:
#	pyproject.toml
#	requirements/requirements-atari.txt
#	requirements/requirements-cloud.txt
#	requirements/requirements-dm_control.txt
#	requirements/requirements-docs.txt
#	requirements/requirements-envpool.txt
#	requirements/requirements-jax.txt
#	requirements/requirements-mujoco.txt
#	requirements/requirements-optuna.txt
#	requirements/requirements-pettingzoo.txt
#	requirements/requirements-procgen.txt
#	requirements/requirements.txt
#	uv.lock
Copy link

vercel bot commented Jul 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cleanrl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2025 2:36pm

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title Gymnasium v1.0 Update to Gymnasium v1.0 Jul 5, 2025
@pseudo-rnd-thoughts
Copy link
Collaborator Author

pseudo-rnd-thoughts commented Jul 6, 2025

Supersuit is broken and needs to be updated as the vector environment returns the wrong info type

@pseudo-rnd-thoughts pseudo-rnd-thoughts mentioned this pull request Jul 7, 2025
57 tasks
# Conflicts:
#	.github/workflows/tests.yaml
#	cleanrl/c51_atari.py
#	cleanrl/c51_atari_jax.py
#	cleanrl/dqn_atari.py
#	cleanrl/dqn_atari_jax.py
#	cleanrl/ppo_atari.py
#	cleanrl/ppo_atari_lstm.py
#	cleanrl/ppo_atari_multigpu.py
#	cleanrl/rainbow_atari.py
#	cleanrl/sac_atari.py
#	pyproject.toml
#	requirements/requirements-atari.txt
#	requirements/requirements-cloud.txt
#	requirements/requirements-dm_control.txt
#	requirements/requirements-docs.txt
#	requirements/requirements-envpool.txt
#	requirements/requirements-jax.txt
#	requirements/requirements-mujoco.txt
#	requirements/requirements-optuna.txt
#	requirements/requirements-pettingzoo.txt
#	requirements/requirements-procgen.txt
#	requirements/requirements.txt
#	uv.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant