Skip to content

Bad contrast for Custom Containers on light theme #1824

@sergejcodes

Description

@sergejcodes

Describe the bug

Since the the theme update in 1.0.0-alpha.37 the text to background contrast ration of Custom Containers got worse. The text became much more difficult to read.

Here's a side-by-side comparison image:

comparison

Reproduction

  1. Go to https://vitepress.vuejs.org/guide/markdown#custom-containers
  2. Switch to light theme

Expected behavior

--vp-custom-block-*-text variables on light theme should be either set to --vp-c-*-dark or --vp-c-*-darker instead of --vp-c-*.

For Example:

:root {
  --vp-custom-block-warning-text: var(--vp-c-yellow-darker);
}

.custom-block.warning {
    color: var(--vp-custom-block-warning-text);
}

System Info

-

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.

Metadata

Metadata

Assignees

Labels

themeRelated to the theme

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions