Skip to content

fix(Suspense): correctly update the transition anchor point #9999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 8, 2024
Merged

fix(Suspense): correctly update the transition anchor point #9999

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
81ab527
fix(Suspense): correctly update the transition anchor point
baiwusanyu-c Jan 4, 2024
cbcfc88
fix(Suspense): updated code
baiwusanyu-c Jan 5, 2024
962f396
fix(Suspense): added unit test
baiwusanyu-c Jan 5, 2024
74388db
fix(Suspense): updated code
baiwusanyu-c Jan 5, 2024
2a6cd39
chore: updated code
baiwusanyu-c Jan 6, 2024
837ddc1
refactor: improve initialAnchor logic
yyx990803 Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/runtime-core/src/components/Suspense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,14 +524,10 @@ function createSuspenseBoundary(
pendingBranch!.transition &&
pendingBranch!.transition.mode === 'out-in'
if (delayEnter) {
const anchor = next(activeBranch!)
activeBranch!.transition!.afterLeave = () => {
if (pendingId === suspense.pendingId) {
move(
pendingBranch!,
container,
next(activeBranch!),
MoveType.ENTER,
)
move(pendingBranch!, container, anchor, MoveType.ENTER)
queuePostFlushCb(effects)
}
}
Expand Down