Skip to content

Add information about non-converged setups #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2025
Merged

Add information about non-converged setups #132

merged 2 commits into from
Feb 5, 2025

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Jan 27, 2025 •
edited
Loading

Summary

Checklist

  • Try to isolate changes into separate PRs (to build a better changelog).
  • Categorize the PR by setting a good title and adding one of the labels:
    change, decision, requirement/quality, requirement/functional, dependency
    as they show up in the changelog
  • Link this PR to related issues if applicable.

@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team January 27, 2025 13:14
zugao
zugao reviewed Jan 30, 2025
View reviewed changes
zugao
zugao approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kidswiss Kidswiss merged commit eef7c56 into master Feb 5, 2025
1 check passed
@Kidswiss Kidswiss deleted the add/non_converged_services branch February 5, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kidswiss @zugao